Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: add more attribute requirements #520

Open
1 task done
MVrachev opened this issue Jan 24, 2024 · 0 comments
Open
1 task done

Task: add more attribute requirements #520

MVrachev opened this issue Jan 24, 2024 · 0 comments

Comments

@MVrachev
Copy link
Member

MVrachev commented Jan 24, 2024

What is the task about?

Attribute requirements implemented in pydantic with the Field class and coint, costr, etc. functions are a useful way to automatically verify that a payload provided by the user are exactly as we want.
Currently, for some attributes such as threshold, bit_length, version, etc. we don't provide such as there is a bug in our FastAPI version. See the discussion here: fastapi/fastapi#9140.
This bug is seen when a new documentation is generated.

As this bug is fixed in the latest FastAPI releases (at the time of writing this is 0.109.0) we can fix this bug and be free to add more requirements to our attributes.
To do this we need to close: #377 first.

For inspiration look at my commit before I realized there is an issue: MVrachev@8a00f5b

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant