Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow dependency detection to work on devDependencies #10167

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Allow dependency detection to work on devDependencies #10167

wants to merge 2 commits into from
+4 −1

Conversation

joglr
Copy link

@joglr joglr commented Oct 28, 2024

This is done to unblock the use case of having most of your dependencies as devDependencies, for CLI's that rely on remix to improve install time by pre-bundling the tool.

Closes: #10166

  • Docs
  • Tests

Testing Strategy:

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4942e99

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Oct 28, 2024

Hi @joglr,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Oct 28, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@joglr
Allow dependency detection to work on devDependencies
3bce8bc 
This is done to unblock the use case of having most of your dependencies as devDependencies, for CLI's that rely on remix to improve install time by pre-bundling the tool.
@joglr
Update contributors.yml
4942e99
@joglr joglr changed the title Allow dependency detection to work on devDependencies fix: Allow dependency detection to work on devDependencies Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
1 participant
@joglr