Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for Rails 5.2? #3450

Open
JRice opened this issue Oct 24, 2019 · 8 comments
Open

No support for Rails 5.2? #3450

JRice opened this issue Oct 24, 2019 · 8 comments

Comments

@JRice
Copy link

JRice commented Oct 24, 2019

I cannot find a version of https://github.com/refinery/refinerycms/blob/4.0.0/core/refinerycms-core.gemspec that allows Rails 5.2.

...Is this intentional? Is there no support for Rails 5.2 in Refinery CMS?

@simi
Copy link
Member

simi commented Oct 24, 2019

AFAIK there's no release for Rails 5.2 support. Rails 6 support is on the way (in master already), Rails 5.2 was added to master, but not released yet -> e49a6be#diff-e61c4dff501e6ff3682da137f9b5761d.

@bricesanchez
Copy link
Member

bricesanchez commented Oct 24, 2019

Hi @JRice,

It was not intentional. Sorry!

Master branch was compatible with Rails 5.2 until this commit 81ed991

We could probably release a new version of Refinery for this Rails version.

What do you think @parndt ?

@parndt
Copy link
Member

parndt commented Oct 24, 2019

Yes, it is probably about time!

@anitagraham
Copy link
Contributor

anitagraham commented Oct 26, 2019

I am in this predicament too. The subtitle for the repository says "...supporting Rails 5.2+" so I think not having a 5.2 compatible release is an oversight.

I'd be happy to move on with Rails 6, but I'm not certain how many refinery extensions will need updating.

@bricesanchez
Copy link
Member

@parndt Could you release a version for rails 5.2 with this commit 81ed991 ?

@theRealNG
Copy link

Waiting for rails 5.2 support atleast

@parndt
Copy link
Member

parndt commented Jan 4, 2020

gem "refinerycms", git: "https://github.com/refinery/refinerycms", ref: "81ed991"

@hdmr14
Copy link

hdmr14 commented Apr 17, 2020

Will 81ed991 released as 4.1.0 or something else?
update directly via github can't manage with versioning causes next update eventually difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants