Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate icons #23

Closed
JayPanoz opened this issue Nov 18, 2024 · 0 comments
Closed

Migrate icons #23

JayPanoz opened this issue Nov 18, 2024 · 0 comments
Assignees
@JayPanoz
Labels
layout

Comments

@JayPanoz
Copy link
Contributor

JayPanoz commented Nov 18, 2024 •
edited
Loading

Right now we’re borrowing icons from Thorium but work being done on actions raised some consistency issues (stroke, sizing, and alignment).

While this could be mitigated with CSS, it’s probably a better idea to migrate to something like Material Symbols and Icons. This could also help further down the line with customisation, re-use, etc.

Longer term, we should keep in mind that developers might want to use alternatives to SVG e.g. icon fonts.
@JayPanoz JayPanoz self-assigned this Nov 18, 2024
@JayPanoz JayPanoz changed the title Migrate to MUI icons Migrate icons Nov 18, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Readium Playground Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JayPanoz JayPanoz

Labels
layout
Projects
Readium Playground
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JayPanoz