-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation of required non-standard components #29
Comments
I tried renaming it to |
Another thing that should be documented: are the chart annotations required? cluster-template-examples/charts/Chart.yaml Lines 5 to 7 in dc5c201
|
I found that there is actually documentation for Also some here: |
I ran into the following error when deploying a custom chart: Secret "helm-operation-ncddt" is invalid:
[
data[foo cluster template-0.35.0.tgz]:
Invalid value:
"foo cluster template-0.35.0.tgz":
a valid config key must consist of alphanumeric characters, '-', '_' or '.'
(e.g. 'key.name', or 'KEY_NAME', or 'key-name', regex used for validation is '[-._a-zA-Z0-9]+'),
data[values-foo cluster template-0.35.0.yaml]:
Invalid value:
"values-foo cluster template-0.35.0.yaml":
a valid config key must consist of alphanumeric characters, '-', '_' or '.'
(e.g. 'key.name', or 'KEY_NAME', or 'key-name', regex used for validation is '[-._a-zA-Z0-9]+')
] This makes it look like Rancher requires there to be files with certain names. WHY ARE THESE REQUIREMENTS NOT DOCUMENTED? 😠 EDIT: I stand to be corrected. This error is completely my fault. My chart had a name that did not conform to the Helm chart naming standards (see Helm documentation or just run |
Please clarify if this is a "Rancher chart". |
Found some details regarding the Helm annotations:
|
The README says this: cluster-template-examples/README.md Line 149 in dc5c201
So I'm no wiser as to whether it requires a specific naming scheme or not for the values files. |
Is this repo still maintained and supported or has SUSE deprecated or given up on this feature? I agree with the items above and I am currently struggling with deciphering the lack of documentation to make this work with vsphere. It is seemingly a cool feature but I have wasted too much time trying to make the examples work and there is a lack of documentation out there that make this consumable by most. I appreciate the links above that were found by @lindhe but I am still unable to spin up a cluster with a template file at the moment. |
Since there is no documentation available on Rancher's website regarding RKE2 cluster templates, I think this repo should do a better job of documenting the special features.
I'm mainly thinking of
questions.yaml
, which is a very important file for this project. I find no reference at all as to how it works, so it's currently all trail and error to figure it out. That's no fun.Furthermore, it should be clarified exactly what Rancher is looking for when a cluster template repo is added to it. As mentioned in #17, the
tgz
file andindex.yaml
files are just decoys. But what about the (oddly named)charts/
directory, does it have to have exactly that name for things to work? It's unclear. I continue to poke and prod my way forward to figure out that too eventually, but it would be better if it was documented.If I've just missed the documentation, please correct me here! :)
Standard components of Helm charts (like the standard fields in the
Chart.yaml
file and thetemplates/
directory) need not to be documented here, since they are described in Helm's documentation.Rancher-specific CRD's like
VmwarevsphereConfig
orManagedChart
should ideally be documented somewhere, but I don't think this repo is the right place for those objects. Also, one can find information about their specification viakubectl explain
, so Rancher's lacking documentation for them is not such a big issue.The text was updated successfully, but these errors were encountered: