Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The resources 'xMachineTemplate-cp' are not pivoted because the ownerReference is not set #500

Open
rletrocquer opened this issue Nov 14, 2024 · 1 comment
Assignees
Labels
kind/bug Something isn't working priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@rletrocquer
Copy link

What happened:
The metal3machinetemplate-cp (or openstackmachinetemplate-cp) resource has no ownerReferences.
As a consequence, the metal3machinetemplate-cp resource is not pivoted between the bootstrap and management clusters via clusterctl move.

What did you expect to happen:
The metal3machinetemplate-cp should have an ownerReferences, and as a consequence, the resource should be pivoted correctly thanks to clusterctl move.

How to reproduce it:
- Create a cluster with capm3 or capo infra_provider and with machinetemplate-cp + machinetemplate-md definitions
- After the cluster creation inspect the machinetemplate-cp resource, no ownerReference is defined (unlike machinetemplate- md)
- After a clusterctl move all resources seems correctly pivoted expect machinetemplate-cp

Anything else you would like to add:
The bug has been reproduced with capm3 and capo as infrastructure providers. The metal3machinetemplate-md is not impacted by the bug. With kubeadm, the metal3machinetemplate-cp correctly has an ownerReferences:

- apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
  kind: OpenStackMachineTemplate
  metadata:
    annotations:
      helm.sh/resource-policy: keep
      meta.helm.sh/release-name: cluster
      meta.helm.sh/release-namespace: sylva-system
    creationTimestamp: "2024-11-13T22:49:48Z"
    generation: 1
    labels:
      app.kubernetes.io/managed-by: Helm
      helm.toolkit.fluxcd.io/name: cluster
      helm.toolkit.fluxcd.io/namespace: sylva-system
      role: control-plane
    name: mgmt-1541381280-kubeadm-capo-cp-73f5b24cfb
    namespace: sylva-system
    ownerReferences:
    - apiVersion: cluster.x-k8s.io/v1beta1
      kind: Cluster
      name: mgmt-1541381280-kubeadm-capo
      uid: b49d9d00-9476-43ae-beb3-99d133d7865b
    resourceVersion: "15845"
    uid: b48fdb3a-3807-4f67-9456-83deacdff784

Environment:
Sylva context
Metal3 or Capo as infra_provider

  • rke provider version: 0.6.0
  • OS (e.g. from /etc/os-release): opensuse and ubuntu

Bug on sylva-side : https://gitlab.com/sylva-projects/sylva-core/-/issues/1839

@rletrocquer rletrocquer added kind/bug Something isn't working needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 14, 2024
@rletrocquer
Copy link
Author

On kubeadm controlplane provider this action is realized via

@alexander-demicev alexander-demicev self-assigned this Nov 26, 2024
@alexander-demicev alexander-demicev added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

2 participants