Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster.spec.clusterNetwork.serviceDomain not propagated into rke2 config (rke2.yaml) #350

Open
tmmorin opened this issue Jun 11, 2024 · 1 comment
Open

Cluster.spec.clusterNetwork.serviceDomain not propagated into rke2 config (rke2.yaml) #350

tmmorin opened this issue Jun 11, 2024 · 1 comment
Labels
kind/bug Something isn't working lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@tmmorin
Copy link

tmmorin commented Jun 11, 2024

There is code to propagate network settings present under spec.clusterNetwork in the CAPI Cluster resource, to the RKE2 configuration:

https://github.com/rancher-sandbox/cluster-api-provider-rke2/blob/main/pkg/rke2/config.go#L190-L200

... but this code does not cover Cluster.spec.clusterNetwork.serviceDomain

This isn't something frequently overridden, and this can I think be worked around by setting RKE2ControlPlane.spec.serverConfig.clusterDomain, so it's a minor issue.
@tmmorin tmmorin added kind/bug Something isn't working needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 11, 2024
@alexander-demicev alexander-demicev added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 27, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmmorin @alexander-demicev