From c479cedc163e0a95016e711a1ce01e16716d0552 Mon Sep 17 00:00:00 2001 From: shima-zu Date: Wed, 20 Nov 2024 23:47:57 +0900 Subject: [PATCH 1/2] Replace `DisabledByDefault` with disabling each cop When `DisabledByDefault` is `true`, all cops in the default configuration. This means that all extension cops are disabled by default. The extensions is outside the scope of omakase, and you may not realize that it has been disabled. --- rubocop.yml | 29 ++++++++++++++++++++++++----- 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/rubocop.yml b/rubocop.yml index 3457ff6..6095637 100644 --- a/rubocop.yml +++ b/rubocop.yml @@ -8,10 +8,33 @@ inherit_mode: AllCops: SuggestExtensions: false - DisabledByDefault: true Exclude: - "data/**/*" +# All cops except your using extensions are disabled by default. +Style: + Enabled: false +Layout: + Enabled: false +Lint: + Enabled: false +Metrics: + Enabled: false +Naming: + Enabled: false +Security: + Enabled: false +Bundler: + Enabled: false +Gemspec: + Enabled: false +Performance: + Enabled: false + Exclude: + - "test/**/*" +Rails: + Enabled: false + # Align `when` with `end`. Layout/CaseIndentation: Enabled: true @@ -152,10 +175,6 @@ Lint/RequireParentheses: Lint/UriEscapeUnescape: Enabled: true -Performance: - Exclude: - - "test/**/*" - Performance/FlatMap: Enabled: true From 5a5b6282541c82196a4d3d44ac440e54d38bb2b6 Mon Sep 17 00:00:00 2001 From: shima-zu Date: Mon, 25 Nov 2024 11:50:31 +0900 Subject: [PATCH 2/2] Listed in ASCII order --- rubocop.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/rubocop.yml b/rubocop.yml index 6095637..535dd33 100644 --- a/rubocop.yml +++ b/rubocop.yml @@ -12,7 +12,9 @@ AllCops: - "data/**/*" # All cops except your using extensions are disabled by default. -Style: +Bundler: + Enabled: false +Gemspec: Enabled: false Layout: Enabled: false @@ -22,18 +24,16 @@ Metrics: Enabled: false Naming: Enabled: false -Security: - Enabled: false -Bundler: - Enabled: false -Gemspec: - Enabled: false Performance: Enabled: false Exclude: - "test/**/*" Rails: Enabled: false +Security: + Enabled: false +Style: + Enabled: false # Align `when` with `end`. Layout/CaseIndentation: