Update to support mint cap switch. #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinaroh
approved these changes
Nov 14, 2018
| export const MINT_CAP = RAHA_UBI_WEEKLY_RATE.times(MAX_WEEKS_ACCRUE); | ||
|
|
||
| // Set to midnight on Nov 16th, 2018 UTC | ||
| const MINT_CAP_TRANSITION_DATE_UTC = Date.UTC(2018, 10, 16); |
There was a problem hiding this comment.
nit: I think moving these consts to shared would be nice
There was a problem hiding this comment.
agreed, I'll do that in a separate PR
| ? `Mint ${maxMintable} Raha now!` | ||
| : `Mint ${maxMintable} Raha before it's too late!`; | ||
| const body = isMintCapped | ||
| ? "You can't get any more basic income until you've minted. Tap to mint now and keep receiving your Raha!" |
There was a problem hiding this comment.
Future work: I'm thinking some people might not want to be notified regularly when they hit the max amount, especially while Raha has no actual value. We should allow users to manage these in in-app Settings and via system-level notification settings (https://developer.android.com/guide/topics/ui/notifiers/notifications Notification Channels on Oreo) so people don't block all notifications from Raha.
There was a problem hiding this comment.
Agreed. Created rahafoundation/raha-mobile-app#508 to track.
Switch to using capped-mintable calculation after 11/16/18 UTC midnight. Also update unminted notification text.
rahulgi
force-pushed
the
rahulgi/enhancement/add-mint-cap-transition-date-switch
branch
from
f3236f4
to
39bf685
Compare
rahulgi
deleted the
rahulgi/enhancement/add-mint-cap-transition-date-switch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using capped-mintable calculation after 11/16/18 UTC midnight.
Also update unminted notification text.