Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL scheme changed in istio 1.6.0 #1

Open
shosti opened this issue May 23, 2020 · 8 comments · May be fixed by #4
Open

URL scheme changed in istio 1.6.0 #1

shosti opened this issue May 23, 2020 · 8 comments · May be fixed by #4

Comments

@shosti
Copy link

shosti commented May 23, 2020

asdf isntall istioctl 1.6.0 doesn't work because istio changed their release naming scheme:

$ asdf install istioctl 1.6.0
Downloading istioctl from https://github.com/istio/istio/releases/download/1.6.0/istio-1.6.0-linux.tar.gz
bin_install_path: /home/shosti/.asdf/installs/istioctl/1.6.0/bin
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100     9  100     9    0     0     32      0 --:--:-- --:--:-- --:--:--    32

gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now

It looks like the correct address is https://github.com/istio/istio/releases/download/1.6.0/istio-1.6.0-linux-amd64.tar.gz .

@idokaraderu idokaraderu linked a pull request Jun 18, 2020 that will close this issue
@shusugmt
Copy link

shusugmt commented Jun 22, 2020

I'm having the exact same issue on Mac with Istio >= 1.6

wrong: https://github.com/istio/istio/releases/download/1.6.3/istio-1.6.3-osx-amd64.tar.gz
correct: https://github.com/istio/istio/releases/download/1.6.3/istio-1.6.3-osx.tar.gz

Until the fix gets merged you can use following workaround:

asdf plugin update istioctl pull/3/head
asdf install istioctl 1.6.3

@mhite
Copy link

mhite commented Aug 10, 2020

I'm on Mac OS X and I'm experiencing the same issue as @shusugmt. For Mac and Windows versions, arch_type should not be used.

I noticed the author (@shosti) of #3 closed their pull request and it was never merged. It would be great if that change or a similar one can be incorporated to address this issue.

@shosti
Copy link
Author

shosti commented Aug 10, 2020

Oh I closed my PR in favor of #2. Is this still an issue?

@shusugmt
Copy link

@shosti yes the problem still exists and your PR is valid.

@paradigm314
Copy link

@rafik8 As mentioned this is still an issue for non-linux installs. Can we get #3 or #4 merged which both account for OS when building the download URL?

@nwillc-paxos
Copy link

nwillc-paxos commented Sep 22, 2020

On the OSX a spurious architecture was getting put in the URL:

asdf install istioctl 1.6.8
Downloading istioctl from https://github.com/istio/istio/releases/download/1.6.8/istio-1.6.8-osx-amd64.tar.gz

bin_install_path: /Users/nchristopher/.asdf/installs/istioctl/1.6.8/bin
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100     9  100     9    0     0     33      0 --:--:-- --:--:-- --:--:--    33
tar: Error opening archive: Unrecognized archive format

The branch 3 does work though. +1 on the merge.

@chadlwilson
Copy link

As much as I prefer to use the official registered plugins, I've given up on this. Seems to have been abandoned given 5 months with no fix?

https://github.com/appfolio/asdf-istioctl seems to work; perhaps we should get the "official" registered plugin replaced with one that is maintained; or move to a fork of this repo?

@RothAndrew
Copy link

As much as I prefer to use the official registered plugins, I've given up on this. Seems to have been abandoned given 5 months with no fix?

https://github.com/appfolio/asdf-istioctl seems to work; perhaps we should get the "official" registered plugin replaced with one that is maintained; or move to a fork of this repo?

IDK what was going on with this one, but it caused all kinds of "permission denied" errors in folders that ASDF should have no business touching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants