Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline css style generation for modals #58

Closed
wants to merge 2 commits into from

Conversation

lenaschoenburg
Copy link
Contributor

Opened in a hurry, I hope this PR works.

This should theoretically fix #57 but currently it breaks animation of modals flying in and out.

@lbradstreet
Copy link
Contributor

Partially looks good. I tried it out and the modal is at least visible, however it shouldn't be position: relative. I have just realised that this is only used in the documentation so that it shows up inline in the docs (i.e. not as a modal). After I remove :position "relative", it all looks good.

@lbradstreet
Copy link
Contributor

Hi @dignati, would you like me to fix this one? I think you just need to remove :position "relative" completely.

@lenaschoenburg
Copy link
Contributor Author

@lbradstreet Sorry, I'm in my finals right now so I totally forgot about this. This should do the trick.
@sritchie Ready to merge?

@lbradstreet
Copy link
Contributor

No worries, and thanks!

On 6 March 2015 at 20:17, Ole Krüger [email protected] wrote:

@lbradstreet https://github.com/lbradstreet Sorry, I'm in my finals
right now so I totally forgot about this. This should do the trick.
@sritchie https://github.com/sritchie Ready to merge?


Reply to this email directly or view it on GitHub
#58 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modals don't work without overriding styles
2 participants