Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild testing #209

Open
ijlyttle opened this issue Jan 31, 2021 · 4 comments
Open

Rebuild testing #209

ijlyttle opened this issue Jan 31, 2021 · 4 comments

Comments

@ijlyttle
Copy link
Member

ijlyttle commented Jan 31, 2021

This is an expansion of #176, this would be a bigger project where we essentially rebuild the testing to use more-recent ideas in testthat.

In "live" testing, each test file should:

  • create and write to its own unique test folder at Box; we can use uuid.
  • delete its folder upon exiting.

We should have persistent folders at Box so that we can test searching.

We can also use snapshot testing to test our translation of Box API responses.

There is a README file in the testthat directory - this should be updated.

@ijlyttle ijlyttle mentioned this issue Jan 31, 2021
@nathancday
Copy link
Member

I'm not sold on the uuid requirement. If re-organizing the tests is motivated by syncing names between R/ files and where they are checked in tests/ file, it feels like we should use those names for the Box folders too. Plus it's another dependency.

@ijlyttle
Copy link
Member Author

ijlyttle commented Feb 3, 2021

The goal is uniquness, to avoid collisions between competing runs of tests, e.g. on my machine and CI. Perhaps the name of the test combined with a millisecond datestamp would do it.

@nathancday
Copy link
Member

nathancday commented Feb 4, 2021 via email

@ijlyttle
Copy link
Member Author

ijlyttle commented Feb 4, 2021

It could be, but I wasn't planning on it - at least until I get the tests reworked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants