Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google/global.txt: Can sometimes freak out on Google Images #414

Open
brian6932 opened this issue Apr 20, 2024 · 3 comments
Open

google/global.txt: Can sometimes freak out on Google Images #414

brian6932 opened this issue Apr 20, 2024 · 3 comments

Comments

@brian6932
Copy link

brian6932 commented Apr 20, 2024

Eats every result, regardless of them being spam or not.

@brian6932 brian6932 changed the title Can sometimes freak out on Google Images google/global.txt: Can sometimes freak out on Google Images Apr 20, 2024
@chuahou
Copy link

chuahou commented May 5, 2024

This issue occurs for me as well on a variety of searches.

With the search query "memtest menu" in private browsing, every image result gets eaten for me.
Illustrating screenshot

I've tested that with every other filter disabled and only "uBlock-Origin-dev-filter – Google+DuckDuckGo – Global" enabled, the results get eaten; with "uBlock-Origin-dev-filter – Google+DuckDuckGo – Global" disabled, the results do not get eaten.

@chuahou
Copy link

chuahou commented Jun 6, 2024

It appears the problem is that the filter list selects the .MjjYud element. On the normal search results page, each .MjjYud corresponds to a single search result, which makes it work perfectly. On the image search results page, however, all the search results are wrapped in a .MjjYud, meaning every result gets eaten if at least one result matches one of the blacklisted domains.

@JoshuaZacek
Copy link

I've found a fix that seems to work for now, although it allows image results to surface from the site you want to blacklist.

I replaced :upwards(.MjjYud) in the filter with :upwards(.Ww4FFb).

So for example, to block Google results from example.com, you'd use google.com###rso .MjjYud a[href*="example.com"]:upward(.Ww4FFb).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants