Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard name mismatch #41

Open
i5ar opened this issue Mar 3, 2019 · 1 comment
Open

Keyboard name mismatch #41

i5ar opened this issue Mar 3, 2019 · 1 comment
Assignees

Comments

@i5ar
Copy link

i5ar commented Mar 3, 2019

The keymaps endpoint (e.g. https://api.qmk.fm/v1/keyboards/1upkeyboards/1up60hse/keymaps/default) shows some lack of congruence. The key keyboard_name, inside keymaps, should be probably called keyboard_folder instead. Thank you.

screenshot

...

screenshot2

This change (if it isn't too late) will also make it more consistent with the info.json:

{
  "keyboard_name": "1up60hse",
  "keyboard_folder": "1upkeyboards/1up60hse",
  "...": "..."
}
@skullydazed skullydazed self-assigned this Mar 3, 2019
@skullydazed skullydazed transferred this issue from qmk/qmk_api Mar 3, 2019
@skullydazed
Copy link
Member

Thanks for bringing this to our attention. We'll look into if there's any ramifications to changing this, I don't think anyone is using it but I'm not entirely sure yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants