Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default max versions #82

Open
pvgladkov opened this issue Mar 21, 2015 · 1 comment
Open

default max versions #82

pvgladkov opened this issue Mar 21, 2015 · 1 comment

Comments

@pvgladkov
Copy link

Since version 0.96 default number of versions is 1. But in happybase this constant is 3 https://github.com/wbolster/happybase/blob/master/happybase/Hbase.thrift#L71.
This difference in behavior is seems to be strange. Maybe should remove this from happybase thus the default number of versions will be determinated only in hbase?

@wbolster
Copy link
Member

Right, I guess the default has changed upstream, since this file is just a copy.

Fwiw, I don't want local modifications to external files since that's a pain to maintain. Updating to a new version and regenerating the Thrift code is the way to go imho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants