- Everyone's code could be less buggy and more flexible. Don't take feedback personal.
- Keep sub-optimal code from getting in the code base.
- Collectively share knowledge and become better developers.
- create a git branch
git checkout -b 'my_feature' - commit to the git branch frequently. (ie 4 or 5 times a day)
- push your git branch to GitLab at least once a day
git push origin my_feature - when you task is complete go to the git lab site and create a pull request
- email everyone about your code review and give them 24 hours to review your code.
- are the dependencies minimized as much as possible?
- good choice of efficient data types for the use/access pattern.
- what OO pattern is being used and is it the right pattern for the job?
- is the public interface only exposing the bare minimum?
- does each public and private minimize use to objects outside of the local scope?
- is the architect following with best practices?
- is the code only building for what today's requirements are?
- is the architect flexible?
- how could this function break? (look at param data structures)
- does it follow the coding styles guidelines?