Skip to content
This repository has been archived by the owner on Jun 2, 2022. It is now read-only.

Move plugin config to the relevant plugin instead of @ top-level #720

Open
ekinanp opened this issue Feb 7, 2020 · 0 comments
Open

Move plugin config to the relevant plugin instead of @ top-level #720

ekinanp opened this issue Feb 7, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@ekinanp
Copy link
Contributor

ekinanp commented Feb 7, 2020

Consider the following wash.yaml file

external-plugins:
  - script: 'foo'
plugins:
  - 'bar'
foo:
  <foo_config>
bar:
  <bar_config>

Having the plugin config @ top-level is a bit confusing. We should change this to something like

external-plugins:
  - script: 'foo'
    config: <config stuff>
plugins:
  - name: 'foo'
    config: <config stuff>

Note that this would also let us configure an external plugin's name so that it doesn't have to be <script_without_extension>. E.g., we could do something like

external-plugins:
  - script: 'bar'
    name: 'foo'
    config: <config>

And Wash would know that the plugin's name is foo.

@ekinanp ekinanp added the enhancement New feature or request label Feb 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant