Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm.V3.Release does not take a ComponentResourceOptions parameter #3254

Open
trondhindenes opened this issue Oct 10, 2024 · 2 comments
Open
Labels
area/docs Improvements or additions to documentation area/helm kind/bug Some behavior is incorrect or out of spec

Comments

@trondhindenes
Copy link

What happened?

According to docs, I should be able to specify a ComponentResourceOptions to the Helm.V3.Release resource. I am unable to do so, the accepted type is CustomResourceOptions. I am unable to find any documentation or examples on how to provide an explicit provider to this resource, and it feels like the docs are wrong

Example

var chart = new Pulumi.Kubernetes.Helm.V3.Release(chartResourceName, new ReleaseArgs
        {
            Name = "nginx", 
            Namespace = "default",
            Chart = "nginx",
            RepositoryOpts = new RepositoryOptsArgs
            {
                Repo = "oci://registry-1.docker.io/bitnamicharts"
            }
        }, new CustomResourceOptions());

Output of pulumi about

I'm not comfortable sharing all that info, but here are the important bits I hope:

CLI          
Version      3.136.1
Go Version   go1.23.2
Go Compiler  gc

Plugins
KIND      NAME          VERSION
resource  azure         6.0.0
resource  azure-native  2.66.0
resource  azuread       5.53.5
language  dotnet        unknown
resource  kubernetes    4.18.1


Dependencies:
NAME                VERSION
Pulumi              3.67.1
Pulumi.Azure        6.0.0
Pulumi.Azuread      5.53.5
Pulumi.AzureNative  2.66.0
Pulumi.Kubernetes   4.18.1

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@trondhindenes trondhindenes added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Oct 10, 2024
@rquitales
Copy link
Member

Hi @trondhindenes, sorry for the confusion regarding setting an explicit provider for v3 Release resources.

I believe this code should work for you:

var chart = new Pulumi.Kubernetes.Helm.V3.Release("mychart", new ReleaseArgs
{
    Name = "nginx", 
    Namespace = "default",
    Chart = "nginx",
    RepositoryOpts = new RepositoryOptsArgs
    {
        Repo = "oci://registry-1.docker.io/bitnamicharts"
    }
}, new CustomResourceOptions { Provider = provider });

You're correct that in C#, the parameter is CustomResourceOptions instead of ComponentResourceOptions. I'll investigate further to understand why this behavior differs in C# compared to other languages.

@rquitales rquitales added area/helm and removed needs-triage Needs attention from the triage team labels Oct 10, 2024
@trondhindenes
Copy link
Author

Hi, thanks for responding. Yup I got to the same conclusion too, so it's not a blocker for me. Still confusing tho.

@EronWright EronWright added the area/docs Improvements or additions to documentation label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Improvements or additions to documentation area/helm kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

3 participants