Fix bigquery table replace hitting "already exists" issue (#2498)

Bigquery materialized views on tables seem to be structural, so due to
pulumi/pulumi#918 the normal pulumi replace of
creating and then deleting does not work.

This PR enables DeleteBeforeRelace by default for the resource, fixing
the issue.

fixes #2491

provider/provider_yaml_test.go

@@ -384,7 +384,7 @@ func writeStackExport(path string, snapshot *apitype.UntypedDeployment, overwrit
 		return fmt.Errorf("stack export must not be nil")
 	}
 	dir := filepath.Dir(path)
-	err := os.MkdirAll(dir, 0755)
+	err := os.MkdirAll(dir, 0o755)
 	if err != nil {
 		return err
 	}
@@ -399,8 +399,9 @@ func writeStackExport(path string, snapshot *apitype.UntypedDeployment, overwrit
 	if pathExists && !overwrite {
 		return fmt.Errorf("stack export already exists at %s", path)
 	}
-	return os.WriteFile(path, stackBytes, 0600)
+	return os.WriteFile(path, stackBytes, 0o600)
 }
+
 func exists(filePath string) (bool, error) {
 	_, err := os.Stat(filePath)
 	switch {
@@ -1314,3 +1315,23 @@ Resources:
 	// We should expect that we refresh cleanly
 	pt.Preview(t, optpreview.ExpectNoChanges())
 }
+
+func TestBigqueryMaterializedViewReplace(t *testing.T) {
+	pt := pulumiTest(t, "test-programs/bigquery-table-materialized-view")
+	pt.SetConfig(t, "gcpProj", getProject())
+	query1 := "SELECT * FROM ${defaultTable.datasetId}.${defaultTable.tableId}"
+	query2 := "SELECT * FROM ${defaultTable.datasetId}.${defaultTable.tableId} WHERE " +
+		"${defaultTable.tableId}.state = 'value'"
+
+	pulumiYAMLContents := pt.ReadPulumiYaml(t)
+
+	// replace query manually to avoid issues with variable interpolation
+	pulumiYAMLContents1 := strings.ReplaceAll(pulumiYAMLContents, "<QUERY>", query1)
+	pt.WritePulumiYaml(t, pulumiYAMLContents1)
+	pt.Up(t)
+
+	// replace query manually to avoid issues with variable interpolation
+	pulumiYAMLContents2 := strings.ReplaceAll(pulumiYAMLContents, "<QUERY>", query2)
+	pt.WritePulumiYaml(t, pulumiYAMLContents2)
+	pt.Up(t)
+}

provider/resources.go

@@ -2095,6 +2095,9 @@ func Provider() tfbridge.ProviderInfo {
 					Source: "privileged_access_manager_entitlement.html.markdown",
 				},
 			},
+			"google_bigquery_table": {
+				DeleteBeforeReplace: true,
+			},
 		},
 		DataSources: map[string]*tfbridge.DataSourceInfo{
 			// Access Approval

provider/test-programs/bigquery-table-materialized-view/Pulumi.yaml

@@ -0,0 +1,53 @@
+name: bigquery-table-materialized-view
+runtime: yaml
+resources:
+  randomName:
+    type: random:RandomString
+    properties:
+      length: 16
+      special: false
+      upper: false
+      number: false
+  default:
+    type: gcp:bigquery:Dataset
+    properties:
+      datasetId: ${randomName.id}
+      friendlyName: test
+      description: This is a test description
+      location: EU
+      defaultTableExpirationMs: 3.6e+06
+      labels:
+        env: default
+  defaultTable:
+    type: gcp:bigquery:Table
+    properties:
+      deletionProtection: false
+      datasetId: ${default.datasetId}
+      tableId: bar
+      timePartitioning:
+        type: DAY
+      labels:
+        env: default
+      schema: |
+        [
+          {
+            "name": "permalink",
+            "type": "STRING",
+            "mode": "NULLABLE",
+            "description": "The Permalink"
+          },
+          {
+            "name": "state",
+            "type": "STRING",
+            "mode": "NULLABLE",
+            "description": "State where the head office is located"
+          }
+        ]        
+  sheet:
+    type: gcp:bigquery:Table
+    properties:
+      deletionProtection: false
+      datasetId: ${default.datasetId}
+      tableId: sheet
+      materializedView: 
+        query: <QUERY>