Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Refactor docker host connection verification #710

Open
guineveresaenger opened this issue Aug 10, 2023 · 0 comments
Open

[chore] Refactor docker host connection verification #710

guineveresaenger opened this issue Aug 10, 2023 · 0 comments
Labels
kind/engineering Work that is not visible to an external user

Comments

@guineveresaenger
Copy link
Contributor

#697 enabled us to automatically fall back to the user socket for the docker host when running Docker locally. This change relies on a live connection verification using the native provider's configureDockerClient function.

This verification check should be more granular and more specifically scoped to local docker hosts, as we encountered #702 and #706 which affected SSH-based connections.

Additionally, we should ensure that the path of information is clear and look into a way to pass DOCKER_HOST to the bridged provider via configuration, not environment variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Development

No branches or pull requests

1 participant