Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation, update error messages for confluent.Environment.get #364

Open
tklusz opened this issue Feb 27, 2024 · 1 comment
Open
Labels
kind/enhancement Improvements or new features

Comments

@tklusz
Copy link

tklusz commented Feb 27, 2024

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

The error message for confluent.Environment.get() returns a 401 Unauthorized: Unauthorized when attempting to call the function without having an API key set. This error message should be updated similar to the error message that occurs when an invalid API Key is set 401 Unauthorized: invalid API key: make sure you're using a Cloud API Key and not a Cluster API Key: <docs>. Something like 401 Unauthorized: unset API key: make sure you set a Cloud API Key: <docs>.

The documentation also needs to be updated to make a clearer distinction between "Confluent Cloud" and "Cloud API Key", calling a key a "Confluent Cloud API key" is ambiguous, as it could be referring to an API key for the "Confluent Cloud" product, or specifically a "Cloud API Key" for Confluent Cloud, a specific type of key in the platform (which is required in this case). That documentation is here - https://www.pulumi.com/registry/packages/confluentcloud/installation-configuration/

I recommend changing the terminology, specifically calling out the difference between Cloud API Key and Cluster API Key. The stack configuration is a bit more clear than the environment variable, being confluentcloud:cloudApiKey instead of CONFLUENT_CLOUD_API_KEY which is more ambiguous.

The README for this project should also be updated to refer to the "Cloud API Key" specifically, as it makes no distinction, i.e. the documentation says the API key for Confluent Cloud should be the Cloud API Key for Confluent Cloud.

Affected area/feature

Error messages for confluentcloud:index:Environment / confluent.Environment.get(), documentation.

@tklusz tklusz added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Feb 27, 2024
@iwahbe iwahbe removed the needs-triage Needs attention from the triage team label Mar 1, 2024
@iwahbe
Copy link
Member

iwahbe commented Mar 1, 2024

Hi @tklusz. Thanks for the feedback.


Related: pulumi/pulumi-terraform-bridge#1585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants