Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only enable minimum set of wasmtime features #27

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alexsnaps
Copy link
Contributor

Updated wasmtime to the latest release and removed some of the otherwise default features that are actually not needed afaict

Some introduce the need for "newer" toolchains (e.g. wat) that might be an issue for some test environments out there, despite the dependency actually not being required.

Copy link

google-cla bot commented Sep 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@alexsnaps
Copy link
Contributor Author

(Crap, I'll redo this PR with my RH, Google CLA approved email), will also update the other deps)

@alexsnaps
Copy link
Contributor Author

alexsnaps commented Sep 18, 2024

Actually don't think that outdated dep is "fixable":

postcard->embedded-io  0.6.1    0.4.0   0.4.0   Normal  ---

given:

name = "postcard"
version = "1.0.10"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "5f7f0a8d620d71c457dd1d47df76bb18960378da56af4527aaa10f515eee732e"
dependencies = [
 "cobs",
 "embedded-io 0.4.0",
 "embedded-io 0.6.1",
 "serde",
]

Where

└── wasmtime v24.0.0
    […]
     ├── postcard v1.0.10

And I'm not even sure it actually gets pulled in, according to cargo --tree and the features of the crate not being in use afaict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant