Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Proxy-Wasm ABI v0.2.0 #2

Open
PiotrSikora opened this issue Aug 11, 2020 · 3 comments
Open

Add support for Proxy-Wasm ABI v0.2.0 #2

PiotrSikora opened this issue Aug 11, 2020 · 3 comments

Comments

@PiotrSikora
Copy link
Member

This is needed to support extensions written using C++ SDK.

@PiotrSikora
Copy link
Member Author

cc @agiachris

@agiachris
Copy link
Contributor

Aside from overlapping signatures of functions exported by the Proxy-Wasm module, there are also a series of host functions that need to be implemented in hostcalls.rs (even if left currently unimplemented for now) for the library to fully support v0.2.0. Leaving this for future reference.

@johnkeates
Copy link

While migrating from a custom implementation to the more standard WASI runtime in Envoy I came across this, so for reference to others, the hostcalls that you might get panics about are mostly going to be the ones listed here: https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/wasm/v3/wasm.proto#extensions-wasm-v3-capabilityrestrictionconfig

The test-framework will stumble over calls like clock_time_get, random_get and environ_get even if you are not directly using them (and using standard functions instead). If the imports are spotted, the framework won't be able to find them right now, as referred to by the two comments above (the not-yet-supported ABI v0.2.0 specifics).

I'm mostly leaving this comment here so others might find it instead of opening duplicated issues (as I was about to do).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants