Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standardized format for upstream names in HTTP/gRPC callouts #61

Open
PiotrSikora opened this issue Oct 3, 2024 · 0 comments
Open

Comments

@PiotrSikora
Copy link
Member

Right now, the upstream name used inside plugin must match configured upstream name in the host, but we don't provide any recommendations around its format, which makes this feature less portable than it could be.

As such, I suggest that we standardize on URI's scheme://authority (e.g. https://www.google.com or udp://1.2.3.4:53) as the upstream name... although that doesn't allow configuration of TLS client certificates, etc.

Note: There is an undocumented behavior in Envoy that allows passing xDS proto with cluster configuration in place of the upstream name, which breaks the security properties of the sandbox, but that's not something supported per existing specification and it shouldn't be used.

cc @kyessenov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant