logger: don't panic in the panic handler #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Martinez Ruiz <[email protected]>
PiotrSikora
reviewed
Feb 26, 2021
| @@ -21,12 +21,20 @@ extern "C" { | |||
| fn proxy_log(level: LogLevel, message_data: *const u8, message_size: usize) -> Status; | |||
| } | |||
|
|
|||
| // Useful for the panic hook to avoid a double-panic. | |||
| #[inline] | |||
| pub(crate) fn log_nopanic(level: LogLevel, message: &str) -> Result<Status, Status> { | |||
There was a problem hiding this comment.
Is there any reason for using Result<Status, Status> instead of Result<(), Status> like rest of the SDK?
There was a problem hiding this comment.
Just leaving the decision about what to do with the Status to the callers out of habit. Since this fn is private to this crate it won't show as part of the SDK to users, and this allows for callers to have more flexibility to make that decision or be extended based on this value without needing to modify this fn.
|
No, I didn't run into it. I just wanted to protect against the possibility that changes happen elsewhere and a new code path opens inadvertently that allows this to happen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a potential double-panic in the panic handler if the logging status code is not recognised.