Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce on_create_child_context hook for creating non root contexts #67

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Introduce on_create_child_context hook for creating non root contexts #67

wants to merge 3 commits into from

Commits on Dec 23, 2020

  1. dispatcher: add on_create_child_context for a simpler way to create c… 

    …ontexts

This introduces a new hook that is called when a new child context is
created from a root context. The implementer can construct and specify the
type of the new context with a single hook method.

This patch is based on work by Yaroslav Skopets <[email protected]>.

Signed-off-by: Alejandro Martinez Ruiz <[email protected]>
    @unleashed
    unleashed committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    80dedf4 View commit details
    Browse the repository at this point in the history

  2. examples: use on_create_child_context to create non http or stream co… 

    …ntexts

Signed-off-by: Alejandro Martinez Ruiz <[email protected]>
    @unleashed
    unleashed committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    2d6c658 View commit details
    Browse the repository at this point in the history

  3. dispatcher: make on_create_child_context the sole way to create non r… 

    …oot ctxts

Having two ways to create non root contexts before introducing
on_create_child_context can cause confusion. This new method is simple
and should cover the usages of the other two in a cleaner way, so let's
remove the others in this _breaking_ change.

Signed-off-by: Alejandro Martinez Ruiz <[email protected]>
    @unleashed
    unleashed committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    471fc54 View commit details
    Browse the repository at this point in the history