Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug use open_grpc_stream create health stream and send failed grpc server panic #260

Closed
pi-pi-miao opened this issue Sep 12, 2024 · 2 comments

Comments

@pi-pi-miao
Copy link

use grpc stream code potential risks panic

example:
match self.open_grpc_stream(
request.get_redis_addr(),
"package.name",
"MetricStream",
vec![],
) {
Err(e) => {
error!("open grpc err {:?}",e);
false
}
Ok(status) => {
// grpc server is health
// sudden the grpc server is crash or other thing
self.send_grpc_stream_message(status, Some(&msg), true); // here will panic ,because grpc server is crash
true
}
}

@PiotrSikora
Copy link
Member

Could you post stacktrace? Does the plugin panic or does the host crash?

@pi-pi-miao
Copy link
Author

Could you post stacktrace? Does the plugin panic or does the host crash?

"Any connection drop would cause a crash due to the underlying error handling using unwrap. I have fixed this issue and resolved numerous crash problems. The fix can be reviewed and merged in the pull request at #264."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants