Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl getRequest/ResponseBodyBufferBytes( ) #109

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Impl getRequest/ResponseBodyBufferBytes( ) #109

wants to merge 1 commit into from

Conversation

Xunzhuo
Copy link
Contributor

@Xunzhuo Xunzhuo commented Apr 22, 2021 •
edited
Loading

image
As doc tells, we should support getRequest/ResponseBodyBufferBytes( ), but actually but impl, so I give PR to fix this.

@Xunzhuo Xunzhuo changed the title Update proxy_wasm_api.h Impl getRequest/ResponseBodyBufferBytes( ) in proxy_wasm_api.h Apr 22, 2021
@Xunzhuo Xunzhuo changed the title Impl getRequest/ResponseBodyBufferBytes( ) in proxy_wasm_api.h Impl getRequest/ResponseBodyBufferBytes( ) Apr 22, 2021
@danehans
Copy link

@PiotrSikora @bianpengyuan can either of you review this PR? If not, do you mind reassigning it to someone else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bianpengyuan bianpengyuan Awaiting requested review from bianpengyuan

@PiotrSikora PiotrSikora Awaiting requested review from PiotrSikora PiotrSikora is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xunzhuo @danehans