-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite load-generator in Go #688
Comments
I would like to pick this up. |
Thanks, @HarshitNagpal29, for the PR. I was also working on this, but my changes are identical to yours, so it's fine. Other than that, the PR looks good. Thanks again. |
I am really sorry for not asking first, I thought you might not be working on it as it was assigned earlier but again completely my fault I should have communicated with you, will take care of this in future. |
@Vandit1604 If you don't open a PR, nobody knows you're working on it. 😄 |
Apologies, I didn't know that. |
Feel free to submit your own solution. The current one does not pass tests. |
I checked and found out that |
Fixed in #748 |
The
/tools/load-generator
is the only component of this repo that is in Python. It would be nice to replace this with a Go binary in order to eliminate the Python ecosystem dependency for one tool. There are also no CI tests for this Python code, so we don't know if it's broken when Python or other requirements change.The text was updated successfully, but these errors were encountered: