Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite load-generator in Go #688

Open
SuperQ opened this issue Jun 16, 2024 · 9 comments
Open

Rewrite load-generator in Go #688

SuperQ opened this issue Jun 16, 2024 · 9 comments

Comments

@SuperQ
Copy link
Member

SuperQ commented Jun 16, 2024

The /tools/load-generator is the only component of this repo that is in Python. It would be nice to replace this with a Go binary in order to eliminate the Python ecosystem dependency for one tool. There are also no CI tests for this Python code, so we don't know if it's broken when Python or other requirements change.

@Vandit1604
Copy link
Contributor

I would like to pick this up.

@HarshitNagpal29
Copy link

@SuperQ PTAL #725

@Vandit1604
Copy link
Contributor

Thanks, @HarshitNagpal29, for the PR. I was also working on this, but my changes are identical to yours, so it's fine.
Please ask in future if somebody is working on an issue to minimize wasted effort.

Other than that, the PR looks good. Thanks again.

@HarshitNagpal29
Copy link

HarshitNagpal29 commented Aug 29, 2024

Thanks, @HarshitNagpal29, for the PR. I was also working on this, but my changes are identical to yours, so it's fine.
Please ask in future if somebody is working on an issue to minimize wasted effort.

Other than that, the PR looks good. Thanks again.

I am really sorry for not asking first, I thought you might not be working on it as it was assigned earlier but again completely my fault I should have communicated with you, will take care of this in future.

@SuperQ
Copy link
Member Author

SuperQ commented Aug 30, 2024

@Vandit1604 If you don't open a PR, nobody knows you're working on it. 😄

@Vandit1604
Copy link
Contributor

Apologies, I didn't know that.

@SuperQ
Copy link
Member Author

SuperQ commented Aug 30, 2024

Feel free to submit your own solution. The current one does not pass tests.

@Vandit1604
Copy link
Contributor

Vandit1604 commented Aug 31, 2024

I checked and found out that http://prombench.prometheus.io/14515/prometheus-pr is not found and is causing the querier to fail, with more than 30 404 status code is returned. I'll investigate the manifest files to see if there's some issue in nginx-ingress configurations.

@SuperQ
Copy link
Member Author

SuperQ commented Sep 21, 2024

Fixed in #748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants