Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: handle nil variableLabels in Desc.String() method and add tests for nil label values #1687

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

kakkoyun
Copy link
Member

Fixes #1684

Signed-off-by: Kemal Akkoyun [email protected]

@kakkoyun kakkoyun requested a review from vesari November 19, 2024 16:02
…for nil label values

Fixes #1684

Signed-off-by: Kemal Akkoyun <[email protected]>
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bwplotka bwplotka merged commit 1880f1b into main Nov 25, 2024
12 checks passed
@bwplotka bwplotka deleted the fix_1684 branch November 25, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prometheus.InvalidDesc.String() is formatted incorrectly
2 participants