Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: value completions are available after the actual value #1394

Open
Druue opened this issue Mar 16, 2023 · 0 comments
Open

bug: value completions are available after the actual value #1394

Druue opened this issue Mar 16, 2023 · 0 comments
Labels
bug/2-confirmed Bug has been reproduced and confirmed. domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/bug A reported bug. tech/engines/datamodel Issue about parsing/validation/rendering of the Prisma schema topic: autocompletion LSP text document completion

Comments

@Druue
Copy link
Contributor

Druue commented Mar 16, 2023 •
edited
Loading

Value completions are available after a value (but not immediately like one space after) -- note, this only seems to affect url completions, completions do not show up again on the same line for provider, schemas, and relationMode.
This will be a logic bug in psl/schema_ast/find_at_position.rs regarding source positions

image

Related:
XYZ_URL showing up as a completion within the text env but not between v and (

image

DIRECT_URL (and the other _URL completions) should only be available as a completion either between the "" if present, or between () of env()
@Druue Druue added bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. tech/engines/datamodel Issue about parsing/validation/rendering of the Prisma schema domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. topic: autocompletion LSP text document completion labels Mar 16, 2023
@Druue Druue mentioned this issue Mar 16, 2023
Merged
29 tasks
@janpio janpio transferred this issue from prisma/prisma Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/2-confirmed Bug has been reproduced and confirmed. domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/bug A reported bug. tech/engines/datamodel Issue about parsing/validation/rendering of the Prisma schema topic: autocompletion LSP text document completion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Druue