Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to disable ANSI coloring #423

Open
vemv opened this issue May 27, 2020 · 5 comments
Open

Ability to disable ANSI coloring #423

vemv opened this issue May 27, 2020 · 5 comments

Comments

@vemv
Copy link

vemv commented May 27, 2020

ANSI coloring appears to be unconditional:

(error! (utils/format* "Input to %s does not match schema: \n\n\t \033[0;33m %s \033[0m \n\n"

...which causes ugly output in my CIDER test buffers:

image

...probably this can be problematic as well in various terminal clients.

I'd suggest introducing a JVM property for deciding whether the user wishes coloring.

WDYT?

Thanks - V

@w01fe
Copy link
Member

w01fe commented May 29, 2020

Yeah, that is unfortunate. If the coloring is problematic, I'd maybe prefer to just remove the coloring entirely. PR welcome!

@vemv
Copy link
Author

vemv commented Jun 10, 2020

Hi @w01fe !

For the time being I don't have the ability to contribute, due to IP concerns.

I'd appreciate the removal which seems simple enough!

Thanks - V

@philomates
Copy link
Contributor

for context, this behavior was introduced in #383

I find it very useful in situations where it correctly renders the colors, so I would vote for some sort of configuration to toggle it

@vemv
Copy link
Author

vemv commented Jun 10, 2020

Yes, I'd be perfectly ok with a JVM property and default to the current behavior

@w01fe
Copy link
Member

w01fe commented Jun 11, 2020

My potential concerns with the JVM property are that (1) there are many potential ways one might want to configure the printing, and (2) I'm not sure how well that will work in CLJS. A printer that's configurable the same way other options are currently (i.e. a var you can rebind with any print function you like) seems like it might be a better solution to me.

In any case, I agree it should be an easy change, but I'm sorry to say I'm personally not actively developing this library at the moment. Another contributor might decide to pick it up, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants