-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compatibility with changes in Om 0.8.0-alpha1/2 #58
Comments
I second this. Have you folks put any time into thinking about 0.8.0? Adrian, are you saying that 0.8.0 fundamentally breaks mixins or just breaks the support Om tools provides for them? |
Mixins are not properly set anymore because the descriptors aren't being set correctly anymore. |
We haven't spent any time with om 0.8.0 API yet, but it is on the radar. If the descriptor API is changing, I would expect mixins to break as well. This happened for om 0.7.0, and was not a problem to move to. That said, mixins are still an experimental feature of om-tools. While we would love to provide a mixin solution, the current approach is not perfect. For example, they are currently not very friendly to advanced compilation (#29). I dont know at this time whether the 0.8.0 changes improve/worsen the situation. @aamedina is there anything specifically that prevents using reference cursors with om-tools? |
Nothing beyond breaking other parts of om-tools (mixins in particular) comes to mind. But there could be other Om implementation details you hook into that have changed in the new release as well, this just stood out. |
+1 from me. I thought I was going crazy trying to get a "hello-world" mixin working with 0.8-alpha2 :). |
What specifically is broken w/ mixins? I'm using Om 0.8.0-alpha2 and om-tools 0.3.6 and have not noticed any issues with mixins. |
The mixins just don't seem to be applied. I had a DebugMixin which simply js/console.log'd on render, downgrading om to 0.7.1 works, 0.8alpha2 didn't. |
I have just tried it again and blow me but it works. I changed the dependency from om 0.7.1 to 0.8.0-alpha2, lein cljsbuild clean then lein figwheel, hard refreshed the browser and lo and behold the console shows the mixin's console.logs. I must have had some dodgy cached version of something somewhere, but yes, om-tools and 0.8.0-alpha2 mixins work for me. |
Going to close this as there doesn't seem to be any concrete breaking changes. Please re-open or create a new issue if any are identified. |
Lots of things have changed with Om in the 0.8.0-alphas, but perhaps the most immediately problematic (vis. compatibility with om-tools) is the way descriptors are set. Mixins no longer work, for example.
Obviously I don't want to pressure you guys to support an alpha version of Om - but personally I want to make use of reference cursors and not lose all of the benefits om-tools provides.
The text was updated successfully, but these errors were encountered: