Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit require of plumbing.core #20

Open
peeb opened this issue Jun 30, 2014 · 1 comment
Open

Explicit require of plumbing.core #20

peeb opened this issue Jun 30, 2014 · 1 comment
Labels

Comments

@peeb
Copy link

peeb commented Jun 30, 2014

Trying out om-tools I noticed that I had to explicitly (:require [plumbing.core :as plumbing]) to get my app to work, despite never calling the plumbing.core namespace anywhere in my own code.

Without the explicit require, I got "plumbing not defined" messages in the console.

This could prove puzzling for developers going forward since the expectation would be that calling om-tools.core/defcomponentk would transparently do the work for you.

@loganlinn
Copy link
Member

Thanks for reporting this. This is definitely not ideal or intended. I'm looking into why this dependency is omitted when compiling CLJS

@loganlinn loganlinn added the bug label Jun 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants