Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Improving Wallet Address sharing #315

Open
gravityz3r0 opened this issue Jan 28, 2019 · 3 comments
Open

[Feature Request] Improving Wallet Address sharing #315

gravityz3r0 opened this issue Jan 28, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@gravityz3r0
Copy link

gravityz3r0 commented Jan 28, 2019

As of RC3, clicking on share button merely forwards the QR code to the recipient.

Situation: I want to receive payment from Bob by sharing my wallet address with him.

Problem: This is not actually very user intuitive because if I were the receiver end of the QR code, how am I supposed to make use of this? Bob can't scan the QR code on his own screen. I simply can't think of any practical use of forwarding QR code to Bob.

Proposed alternative:

When sharing button is clicked, an unique link is generated and forwarded to Bob instead. The link can contain a message of something along the line of :

"Hey there! This is my wallet address. You can send the fund to me by clicking the following link: decred://unique.address.link"

When this link is clicked, Decred Wallet is automatically launched with "Send" windows in view by default and my (the sharer) wallet address automatically populated. Bob, who opened this link would then only need to fill up the amount before clicking send.

QR code screenshot can still be forwarded along with this link in case someone else wanted to scan from Bob's screen, or have it removed altogether.

(I know there is a copy and paste feature but this is just a more graceful solution)

@raedah
Copy link
Contributor

raedah commented Jul 18, 2019

It does sound ideal, but in practice this all has to be handled by the operating system. There is no way for the OS to know to use that link to launch the play store if the app isnt installed, and if we are able to configure the app to at least launch on the link...its completely dependent on the messaging app that the users receives the msg on if they want to support the link, and even if the link is supported, multiple wallet programs are all going to try and register with the OS to be able to be the app that gets launched by the link. Worst case scenario, malicious apps try to use the link to trick users into making transactions. Users will also be sending the link to other users who use different apps and the link wont work for them, creating lots of failure conditions. Overall, this idea has been tried many times in the past and never really works.

@dreacot
Copy link
Contributor

dreacot commented Sep 22, 2021

it's a possibility, similar feature is implemented in the bitcoin.com wallet app for android

@dreacot dreacot added the enhancement New feature or request label Sep 24, 2021
@gravityz3r0
Copy link
Author

gravityz3r0 commented Jan 1, 2022

As an interim, i think implementing a feature to "Import Screenshot" of the said QR code is good enough. It's probably more straightforward and less complex that way. I have seen this method being implemented in numerous other financial apps and it turned out working well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants