Replies: 2 comments
-
We probably need a standalone executable to run explorer in the long run, but IMHO the easiest way at present would be dropping Libplanet.Explorer.Executable. Instead, we could properly implement light node (i.e., node with no action loaded) in the future. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Even if we're going to drop Libplanet.Explorer.Executable, we need to move subcommand Cc @moreal. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Currently, Libplanet.Explorer.Executable is designed in a way that it is agnostic about what the actions in the given chain look like, by providing a no-op action
NullAction
asT
to theBlockChain<T>
object. On action evaluation, this action did nothing and returned an empty state. This should have worked until the introduction of state root hashes, but now that the state root hash of each blocks are checked against the execution result, getting the correct state root hash requires Libplanet.Explorer.Executable to use the correct action types for each chain it hosts, and otherwise renders it unusable. We have to decide whether to decommission it, or make it work in other means. See also: #2243Beta Was this translation helpful? Give feedback.
All reactions