Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

by_value option not respected #22

Open
Bilge opened this issue Nov 26, 2015 · 1 comment
Open

by_value option not respected #22

Bilge opened this issue Nov 26, 2015 · 1 comment

Comments

@Bilge
Copy link
Contributor

Bilge commented Nov 26, 2015

Regardless of the by_value setting, AbstractMongoStrategy::hydrateCollection always attaches AllowRemoveByValue strategy. When by_value is false it should attach AllowRemoveByReference instead.

@veewee
Copy link
Contributor

veewee commented Dec 1, 2015

The hydration of the object still respects the by_value configuration. The strategy is something that is configured to extract / hydrate a property. So the strategy does not NEED to respect the hydrator. It is something stand-alone that is attached to the hydrator.

I agree that in an ideal situation you could choose between the strategy base class. However this won't be an easy fix. It is also not a good idea to create duplicate strategies just to respect the by_value configuration of the main hydrator. We will propably have to think this one through.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants