Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LB timeout in QueryServer #893

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

vishalkrishnads
Copy link
Contributor

@vishalkrishnads vishalkrishnads commented Aug 20, 2024

Description

The query server takes quite a while to process incoming requests. But, most load balancers timeout before the computation can be completed.

As a temporary fix, this PR configures the query handler to send a one byte HTTP 202 response after waiting for P_PROXY_TIMEOUT - 5 seconds if the computation hasn't finished. The client can then reach back out with the same query after a while. If the results are ready, the server responds, or it times out again. The result persists in the cache and can be reused for the same query later.


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht requested review from parmesant and nikhilsinhaparseable and removed request for parmesant August 20, 2024 07:52
@vishalkrishnads vishalkrishnads changed the title Configured keep alive for QueryServer Fix LB timeout in QueryServer Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants