feat: audit logs #994
Open
feat: audit logs #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Akshat Agarwal <[email protected]>
de-sh
reviewed
Nov 19, 2024
| pub audit_log_target_username: Option<String>, | ||
| pub audit_log_target_password: Option<String>, | ||
| pub audit_log_target_tls_verify: bool, | ||
| pub audit_log_target_headers: HashMap<String, String>, |
There was a problem hiding this comment.
This could just as well be an http::HeaderMap
de-sh
reviewed
Nov 19, 2024
| .get("user-agent") | ||
| .and_then(|value| value.to_str().ok()) | ||
| .unwrap_or("unknown"), | ||
| "id": "user123" |
There was a problem hiding this comment.
Why is this hardcoded, and what is the intention behind using user-agent as type?
| .unwrap_or("unknown"), | ||
| "id": "user123" | ||
| }, | ||
| "ip-address":&req |
There was a problem hiding this comment.
Are you intending to use the addr of the client?
| @@ -164,6 +171,31 @@ where | |||
| /* ## Section end */ | |||
|
|
|||
| let auth_result: Result<_, Error> = (self.auth_method)(&mut req, self.action); | |||
| let body = json!([ | |||
There was a problem hiding this comment.
I will work on the Schema, will get back to you in a week's time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR so it makes it easier to discuss adding audit logs to parseable.
Fixes #765.
What kind of events do we want to capture?
Adding any other details to the audit log
This PR has: