Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore sharex unless subplots=True #60299

Open
mdruiter opened this issue Nov 13, 2024 · 2 comments · May be fixed by #60323
Open

Ignore sharex unless subplots=True #60299

mdruiter opened this issue Nov 13, 2024 · 2 comments · May be fixed by #60323
Labels
Needs Discussion Requires discussion from core team before further action Visualization plotting

Comments

@mdruiter
Copy link
Contributor

mdruiter commented Nov 13, 2024 •
edited
Loading

I was trying sharex=True in df.plot(). That confused me. I think it's because sharex was only designed to work with subplots=True. It does something with subplots=False (the default) as well, except it's not clear what and it doesn't make much sense.

My suggestion would be, in the case that subplots=False, to either ignore sharex (and sharey?) altogether or warn when it is specified (or both).
@TinoDerb
Copy link

I would say that at least a warning should be thrown to the user that sharing axis should be coupled with subplots=True. Am not a very big github user, this issue can be remedied by a simple condition and warn statement.

@MehdiNemri MehdiNemri linked a pull request Nov 15, 2024 that will close this issue
Open
5 tasks
@rhshadrach
Copy link
Member

Thanks for the report!

It does something with subplots=False (the default) as well, except it's not clear what and it doesn't make much sense.

I think we need a better understanding here before deciding what way forward is appropriate.

@rhshadrach rhshadrach added Visualization plotting Needs Discussion Requires discussion from core team before further action labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Discussion Requires discussion from core team before further action Visualization plotting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add warning for sharex/sharey when subplots=False in plot method MehdiNemri/pandas
3 participants
@mdruiter @rhshadrach @TinoDerb