Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH1037 Remove na_sentinel from factorize methods #1038

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

GH1037 Remove na_sentinel from factorize methods #1038

wants to merge 5 commits into from
+17 −7

Conversation

loicdiridollou
Copy link
Contributor

Dr-Irv
Dr-Irv requested changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To close the issue, you will have to also edit pandas-stubs/core/base.pyi as well. Basically anywhere that def factorize() appears, and then reconcile it with the docs.

pandas-stubs/core/arrays/base.pyi Outdated Show resolved Hide resolved
tests/test_pandas.py Outdated Show resolved Hide resolved
@loicdiridollou
Copy link
Contributor Author

All should align with the docs now, let me know if anything extra is needed.

Dr-Irv
Dr-Irv requested changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also update core/base.pyi that has a the declaration for Index.factorize() ?

@loicdiridollou
Copy link
Contributor Author

loicdiridollou commented Nov 21, 2024 •
edited
Loading

Aahh I see what you mean, sorry I got confused, added a test on the side, the type hinting seems a bit broad on it but that is for another day.
Now it aligns with the docs https://pandas.pydata.org/docs/reference/api/pandas.Index.factorize.html#pandas.Index.factorize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Irv Dr-Irv Awaiting requested review from Dr-Irv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removed na_sentinel argument from factorize(), Index.factorize(), and ExtensionArray.factorize()
2 participants
@loicdiridollou @Dr-Irv