Skip to content
This repository has been archived by the owner on Jun 12, 2023. It is now read-only.

ENH: set version as shell variable #15

Open
jbrockmendel opened this issue Oct 18, 2019 · 2 comments
Open

ENH: set version as shell variable #15

jbrockmendel opened this issue Oct 18, 2019 · 2 comments

Comments

@jbrockmendel
Copy link
Member

The first step in the instructions is to edit the make file manually. Instead of editing the TAG and setting github username manually there, we should have the user export TAG as a shell variable. (github username we can get with git config --get user.name under mild assumptions).

Two upsides:

  1. don't ask the user to modify any files inplace
  2. On line 39 of the readme there is an ambiguous make pandas/dist/<>.tar.gz that can be made unambiguous using shell expansion.
@WillAyd
Copy link
Member

WillAyd commented Oct 18, 2019

Makes sense. Could also pass directly from CLI . Either would be an upgrade

https://stackoverflow.com/questions/2826029/passing-additional-variables-from-command-line-to-make

@TomAugspurger
Copy link
Collaborator

FWIW, you can do this now.

diff --git a/Makefile b/Makefile
index 0d79fa0..bdfe2b8 100644
--- a/Makefile
+++ b/Makefile
@@ -8,6 +8,10 @@ TARGZ=pandas-$(PANDAS_VERSION).tar.gz
 # to ensure pushd and popd works
 SHELL := /bin/bash
 
+
+print-tag:
+	echo $(TAG)
+
 # -----------------------------------------------------------------------------
 # Host filesystem initialization
 # -----------------------------------------------------------------------------
bash-5.0$ make print-tag TAG=v1.0.0
echo v1.0.0
v1.0.0
bash-5.0$ TAG=v1.0.0 make print-tag
echo v1.0.0
v1.0.0

but you need to remember to always use it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants