Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump scala-collection-compat dependency to 2.12.0 (fix Scala Native 0.5 support) #591

Closed
david-bouyssie opened this issue Jun 4, 2024 · 2 comments

Comments

@david-bouyssie
Copy link

scala-collection-compat was recently updated to add support for Scala Native 0.5.0
scala/scala-collection-compat#651

Could you please upgrade the scribe dependencies to use the latest scala-collection-compat?
https://mvnrepository.com/artifact/org.scala-lang.modules/scala-collection-compat_2.12/2.12.0

This should solve the following issue in an sqlite4s PR (david-bouyssie/sqlite4s#7) and maybe similar issues in other scribe dependents:

[error] Unknown type scala.jdk.CollectionConverters$, referenced from:
[error]          method scribe.mdc.MDCMap.map(): scala.collection.immutable.Map at MDCMap.scala:12
[error]          method scribe.LoggerSupport$.apply(scribe.Level, scala.collection.immutable.List, sourcecode.Pkg, sourcecode.FileName, sourcecode.Name, sourcecode.Line, scribe.mdc.MDC): scribe.LogRecord at LoggerSupport.scala:115
[error]          method scribe.LoggerSupport.log(scribe.Level, scribe.mdc.MDC, scala.collection.Seq, sourcecode.Pkg, sourcecode.FileName, sourcecode.Name, sourcecode.Line): java.lang.Object at LoggerSupport.scala:16
[error]          method scribe.Logger.log(scribe.Level, scribe.mdc.MDC, scala.collection.Seq, sourcecode.Pkg, sourcecode.FileName, sourcecode.Name, sourcecode.Line): scala.runtime.BoxedUnit at Logger.scala:71
[error]          method scribe.Logger.log(scribe.Level, scribe.mdc.MDC, scala.collection.Seq, sourcecode.Pkg, sourcecode.FileName, sourcecode.Name, sourcecode.Line): java.lang.Object at Logger.scala:18
[error]          method scribe.LoggerSupport.info(scala.collection.Seq, sourcecode.Pkg, sourcecode.FileName, sourcecode.Name, sourcecode.Line, scribe.mdc.MDC): java.lang.Object at LoggerSupport.scala:37
[error]          method scribe.Logger.info(scala.collection.Seq, sourcecode.Pkg, sourcecode.FileName, sourcecode.Name, sourcecode.Line, scribe.mdc.MDC): java.lang.Object at Logger.scala:18

Thanks!

@david-bouyssie
Copy link
Author

Thank you very much ❤️

@darkfrog26
Copy link
Contributor

You have @lolgab to thank. He did all the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants