Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute new publisher type #422

Open
lukehinds opened this issue Jan 26, 2024 · 3 comments
Open

Contribute new publisher type #422

lukehinds opened this issue Jan 26, 2024 · 3 comments

Comments

@lukehinds
Copy link

Hello,

I am interested in contributing a new publisher. This will essentially be a simple http client that will post published events to a configurable endpoint;

e.g...

publisher:
  type: 'http-client'
  config:
    http_client_config:
      url: 'http://127.0.0.1:8081/events'  # Replace with your actual URL

image

I wanted to see what the communities appetite is before I rock up with a PR and no previous context. This will make feeds a key part of our platform and so on-going maintenance of the client will be a responsibility we are willing to take on for the long term.

@lukehinds
Copy link
Author

I am sorry, I just noticed this afterwards #386

Happy to move the conversation there if better,

@calebbrown
Copy link
Contributor

Hi Luke, it makes sense to consolidate the conversation into #386.

Your basic proposal makes sense and we'd be happy to accept contributions.

I'm keen for a bit more clarity around error handling, retries, etc too.

@lukehinds
Copy link
Author

I'm keen for a bit more clarity around error handling, retries, etc too.

That makes sense. We will make sure those are all covered off, would it work for you to review the approach within the context of a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants