Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add "data_type" tag to make parsing easier #30

Open
kurtseifried opened this issue Feb 2, 2022 · 1 comment
Open

Please add "data_type" tag to make parsing easier #30

kurtseifried opened this issue Feb 2, 2022 · 1 comment

Comments

@kurtseifried
Copy link
Contributor

Please add "data_type" tag to make parsing easier, for example the CVE JSON format has:

"data_type": "CVE" which means you don't have to guess and test to see what kind of data you're parsing. If the OSV ould add a " "data_type": "OSV" to everything that would make life much simpler. Especially if more people start using things like OSV's database_specific field to embed OSV data into other formats (cats and dogs living together, it's turtles all the way down).

@oliverchang
Copy link
Contributor

Thanks for raising this! In hindsight we should have named our schema_version osv_version or something similar instead, but we are no longer able to change this for compatibility reasons.

A data_type field is a possibility, but I wonder if there are other ways we can infer this without adding another field to the schema, (e.g. with how GSD is using it today).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants