Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding "modern" JS pipeline & stack #9

Open
prmtl opened this issue May 4, 2018 · 8 comments
Open

Consider adding "modern" JS pipeline & stack #9

prmtl opened this issue May 4, 2018 · 8 comments

Comments

@prmtl
Copy link
Collaborator

prmtl commented May 4, 2018

I was thinking about adding some "modern" pipeline to the project, to make writing code more pleasant. What I mean by that: right now it is written in plain ES5 which is missing some neat features. I thought about porting it piece by piece to ES6 but it would require to use tools like Babel transpiler, npm or yarn for installing dependencies, etc.

This would complicate initial setup and updates on the server which IMHO is a big obstacle.

Also the stack would case a higher entry level for potential contributors, since it is easier to write some spaghetti JavaScript full of jQuery than learn first about dependency management with npm/yarn

@kocio-pl
Copy link
Member

kocio-pl commented May 4, 2018

I don't know if you're aware that @dotevo is working on the new code, probably https://github.com/dotevo/osm24/tree/osm24v2 is the basic of this. If you want something modern, you can talk to him, I guess. This is a legacy fork and I'm even not a coder, but if you want to develop it into something modern, it's perfectly possible.

@prmtl
Copy link
Collaborator Author

prmtl commented May 4, 2018

Yes, I'm aware of it.

OK, so if there is no strong voice against it (moving to some "modern" stack), I'll slowly work on it.

@dotevo
Copy link
Contributor

dotevo commented May 4, 2018

osm24v2 is not this what I'm doing right now. It is dead branch. I keep project on private repository. It is uses npm + gulp ES6 etc. But I'm not sure if I will publish it - or maybe yes but when will be ready. But project is not created in English so I do not think that anyone will want to contribute to it XD

@kocio-pl
Copy link
Member

kocio-pl commented May 4, 2018

If it will be interesting, it can be simply translated into English.

But given that you're not sure yet, modernizing osm24 makes perfect sense for me.

BTW @prmtl ask for joining osm-pl team so you can merge the code yourself.

@kocio-pl
Copy link
Member

kocio-pl commented May 4, 2018

This fork had very simple goal - cleaning a bit and adding Polish translation. I didn't expect that someone else might be so interested. So I think of making all the basic stuff and make it 1.0.0 release to state it clearly and then move forward with a full blown rework.

@prmtl
Copy link
Collaborator Author

prmtl commented May 4, 2018

@kocio-pl Cool, AFAIK someone just need to add me to collaborators, no way to "ask to join".

@kocio-pl
Copy link
Member

kocio-pl commented May 4, 2018

I thought that I have no such right, but it looks that I have. I have added you and now the invitation needs to be confirmed by you.

@kocio-pl
Copy link
Member

Hi! If you feel like, you can do whatever you want - it does not look like anything is going on with this code for a year and I don't want to block you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants