-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #4781: Adds Edit + Add Page ScrollToTopPage() On Settings Tab Form Error Messages #4782
base: dev
Are you sure you want to change the base?
Conversation
…sage - Adds await ScrollToPageTop(); to error messages - Adds Blank Page Name Error Message
@thabaum the page name validation is already handled in the existing code: There is a required attribute on the field:
and a form validator in the Save method:
This handles all of the required fields. |
@sbwalker I guess I was thinking about this error message ' Just seemed more friendly to have the error message tell what is the issue instead of looking for a red x in the form for the blank page which I think is the only one you can really mess up beside the effective date on the form. This message however does not get fired off when the page is blank. Instead you get this one: A more generic message for this error which I understand is probably preffered. I can remove the message enhancements I suppose it is a bit more simple to keep it just a message that makes a user review the entire form. |
@sbwalker I went ahead and removed the added error message for blank page name. This just focuses on scroll to top of page functionality on error messages. |
Fixes #4781: