Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Admin - Site Settings: No notification when saving settings successfully. #4760

Closed
thabaum opened this issue Oct 21, 2024 · 4 comments
Closed

Comments

@thabaum
Copy link
Contributor

thabaum commented Oct 21, 2024

Oqtane Info

Version - 5.2.4
Render Mode - Static
Interactivity - Server
Database - SQL Server

Describe the bug

Admin - Site Settings: No notification when saving settings successfully.

Expected Behavior

a notification at the top of the page is shown with an error or success message

Steps To Reproduce

expand sections in site settings so you need to scroll up.
save site settings
notice no success or error message message to let a user know an action was performed.

Anything else?

@sbwalker
Copy link
Member

this is because a full page refresh is required in Site Settings to handle scenarios where the theme, UI component settings, etc... have been modified.

@zyhfish
Copy link
Contributor

zyhfish commented Oct 23, 2024

how about to add a query string in the redirect URL, then we can display successful message when the query string is appended.

@sbwalker
Copy link
Member

@zyhfish although that solution would work, it feels more like a workaround than a proper solution.

@sbwalker
Copy link
Member

sbwalker commented Oct 23, 2024

@zyhfish actually, I am not opposed to this solution in this specific scenario - please go ahead and submit a PR (just make sure it works in both static and interactive render modes)

@sbwalker sbwalker reopened this Oct 23, 2024
sbwalker added a commit that referenced this issue Nov 22, 2024
fix #4760 - display update confirmation message in Site Settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants