-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not being able to fetch type metadata should not fail verification? #258
Comments
Hi @TimoGlastra , you can pass a parameter if the metadata should be loaded from the vct by setting a config value: https://github.com/openwallet-foundation/sd-jwt-js/blob/main/packages/sd-jwt-vc/src/sd-jwt-vc-config.ts#L18 For the error for schema fetching we have this error message: https://github.com/openwallet-foundation/sd-jwt-js/blob/main/packages/sd-jwt-vc/src/sd-jwt-vc-instance.ts#L252 But in the fetch function it's generic in the |
The config option assumes you know upfront whether the SD-JWT has type metadata. I'd like to fetch the type metadata if it exists, but if the endpoint returns 404 that seems fine to me. |
When you are activating the You are able to overwrite the So when you want to perform schema validation and you know you will get other values than URL in the vct that, you need to overwrite this function by passing it. |
As I understand the SD-JWT VC specification, the
vct
CAN be used to represent the type metadata URL, but i don't think it's invalid to usehttps://
uri for vct and not host type metadata?Also the error message is the response of the VCT, which can be confusing. Instead of using
response.text()
as the error message, maybe it should beError fetching type metadata. ${await response.text()}
?The text was updated successfully, but these errors were encountered: