Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: contributor attributed twice for same file #191

Open
nickytonline opened this issue Sep 15, 2024 · 7 comments
Open

Bug: contributor attributed twice for same file #191

nickytonline opened this issue Sep 15, 2024 · 7 comments
Labels
🐛 bug Something isn't working 👀 needs triage

Comments

@nickytonline
Copy link
Member

You can see this in action in https://github.com/open-sauced/landing-page/pull/362/files. Look for @zeucapua and you'll notice it appears twice on multiple files, e.g.

components/sections/navigation/Header.tsx @brandonroberts @zeucapua @zeucapua

CleanShot 2024-09-15 at 08 59 23

This doesn't break anything and it's still a valid CODEOWNERS file, but it should be cleaned up.

@nickytonline nickytonline added 🐛 bug Something isn't working 👀 needs triage labels Sep 15, 2024
@jpmcb
Copy link
Member

jpmcb commented Sep 16, 2024

Which version was this on? I think this was fixed recently so my guess is this was from an older version of the CLI

@nickytonline
Copy link
Member Author

nickytonline commented Sep 16, 2024

Which version was this on? I think this was fixed recently so my guess is this was from an older version of the CLI

Looks like it was v1.5.0-beta.2.0.20240913205418-ea2b4a9594e9

I'll upgrade the pizza-action and see if it still persists in the landing page project.

@nickytonline
Copy link
Member Author

Confirmed that with 2.1.0, this is still an issue.

Get latest from the open-sauced/landing-page project and run pizza generate codeowners ./. Notice Zeu appears twice.

CleanShot 2024-09-16 at 14 26 59

@jpmcb
Copy link
Member

jpmcb commented Sep 16, 2024

Confirmed that with 2.1.0, this is still an issue.

Huh weird - I'll look into this. It shouldn't be able to have double the attributions since it uses a straight mapping of usernames to emails.

@takanome-dev
Copy link

Noticed the same:

pizza version
Version: v2.1.0
Sha: a659d86cd3a88d1856f4f1bd345e2b4d92fa4dd5
Built at: 2024-09-16-22:55:27
.eslintrc.js @takanome-dev @takanome-dev
.github/workflows/development.yml @renovate[bot]
.prettierrc @takanome-dev @takanome-dev
CHANGELOG.md @El Hadji Malick Seck @El Hadji Malick Seck @dependabot[bot]
env.mjs @takanome-dev @takanome-dev
log.log @takanome-dev @takanome-dev
next.config.mjs @El Hadji Malick Seck @El Hadji Malick Seck
package.json @El Hadji Malick Seck @El Hadji Malick Seck @renovate[bot] @takanome-dev @takanome-dev

@jpmcb
Copy link
Member

jpmcb commented Sep 17, 2024

As a side note: this won't affect GitHub's CODEOWNERS automation. It'll still be able to automatically request review from whomever is attributed on that file

@nickytonline
Copy link
Member Author

You can see this in action in this latest PR open-sauced/landing-page#383. It's using v.2.2.0 of the pizza CLI, https://github.com/open-sauced/landing-page/actions/runs/11197287184/job/31127055020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 👀 needs triage
Projects
None yet
Development

No branches or pull requests

3 participants